Skip to content

fix(test): declare direct esbuild dependency for manifest tests - #1

Draft
CodePhrex wants to merge 1 commit into
mainfrom
fix/declare-manifest-esbuild
Draft

CodePhrex wants to merge 1 commit into
mainfrom
fix/declare-manifest-esbuild

Conversation

@CodePhrex

@CodePhrex CodePhrex commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Scope

Declare esbuild as a direct development dependency because tests/manifest.test.mjs imports it directly. This avoids relying on Vite's transitive dependency hoisting during clean installs.

Verification (November 12, 2026)

  • Static inspection: npm test invokes node --test tests/manifest.test.mjs, which imports esbuild.
  • Windows Actions run #68 completed successfully for PR head 448e9251dfe38f9a412bb6bb6cdf8243823a41b6.
  • Job steps succeeded: dependency installation, manifest regression tests, desktop frontend build, Tauri Windows installer build, installer existence verification, and artifact uploads.
  • Installer and portable executable artifacts were present and unexpired when checked November 12, 2026; scheduled expiry November 25, 2026.
  • Interactive Windows application behavior was not manually tested. No runtime application, .dui format, or export code changed.

Follow-up

After review/integration, expand .dui save/open regression coverage in a separate focused change. Keep this dependency-only PR isolated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant